linux-kernel - Re: [PATCH] arm64: dts: qcom: sagit: add initial device tree for sagit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8ee994fc-c5a5-804f-16b7-3502f25b5a53@linaro.org>
Date:   Mon, 8 Aug 2022 09:10:50 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Dzmitry Sankouski <dsankouski@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sagit: add initial device tree for
 sagit

On 05/08/2022 16:06, Dzmitry Sankouski wrote:
> сб, 18 июн. 2022 г. в 04:54, Krzysztof Kozlowski <
> krzysztof.kozlowski@...aro.org>:
> 
>> On 17/06/2022 05:20, Dzmitry Sankouski wrote:
>>> New device support - Xiaomi Mi6 phone
>>>
>>> What works:
>>> - storage
>>> - wlan
>>> - touchscreen
>>>
>>> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>>>  .../boot/dts/qcom/msm8998-xiaomi-sagit.dts    |  12 +
>>>  .../boot/dts/qcom/msm8998-xiaomi-sagit.dtsi   | 628 ++++++++++++++++++
>>>  3 files changed, 641 insertions(+)
>>>  create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
>>>  create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile
>> b/arch/arm64/boot/dts/qcom/Makefile
>>> index 2f8aec2cc6db..aa50843dbe12 100644
>>> --- a/arch/arm64/boot/dts/qcom/Makefile
>>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>>> @@ -48,6 +48,7 @@ dtb-$(CONFIG_ARCH_QCOM)     +=
>> msm8998-oneplus-dumpling.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)      += msm8998-sony-xperia-yoshino-lilac.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)      += msm8998-sony-xperia-yoshino-maple.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)      += msm8998-sony-xperia-yoshino-poplar.dtb
>>> +dtb-$(CONFIG_ARCH_QCOM)      += msm8998-xiaomi-sagit.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)      += qcs404-evb-1000.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)      += qcs404-evb-4000.dtb
>>>  dtb-$(CONFIG_ARCH_QCOM)      += qrb5165-rb5.dtb
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
>> b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
>>> new file mode 100644
>>> index 000000000000..0791615ec5da
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
>>> @@ -0,0 +1,12 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/* Copyright (c) 2016, The Linux Foundation. All rights reserved. */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "msm8998-xiaomi-sagit.dtsi"
>>> +
>>> +/ {
>>> +     model = "Xiaomi Mi 6";
>>> +     compatible = "xiaomi,sagit", "qcom,msm8998";
>>
>> You need to document the compatible.
>>
> You mean a document file with all msm8998 boards compatible properties
> info, like for example, stm did in
> Documentation/devicetree/bindings/arm/stm32/stm32.yaml ?

I mean, add it to existing bindings with Qualcomm board compatibles.

Best regards,
Krzysztof