[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 8 Aug 2022 11:42:34 +0300
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Yassine Oudjana <yassine.oudjana@...il.com>,
Sebastian Reichel <sre@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>
Cc: Yassine Oudjana <y.oudjana@...tonmail.com>,
Alejandro Tafalla <atafalla@...on.com>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
linux-pm@...r.kernel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, phone-devel@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] dt-bindings: power: supply: Add DT schema for
Qualcomm SMBCHG
On 08/08/2022 10:34, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@...tonmail.com>
>
> Add DT schema for the switch-mode battery charger found on Qualcomm
> PMICs such as PMI8994. Due to lack of documentation, some interrupt
> descriptions might be inaccurate.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> ---
> .../bindings/power/supply/qcom,smbchg.yaml | 205 ++++++++++++++++++
> MAINTAINERS | 8 +
> 2 files changed, 213 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml b/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
> new file mode 100644
> index 000000000000..d825a9c10b3e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
> @@ -0,0 +1,205 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/qcom,smbchg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm PMIC Switch-Mode Battery Charger
> +
> +maintainers:
> + - Yassine Oudjana <y.oudjana@...tonmail.com>
> + - Alejandro Tafalla <atafalla@...on.com>
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,pmi8994-smbchg
> + - qcom,pmi8996-smbchg
> +
> + reg:
> + maxItems: 1
> +
> + monitored-battery:
> + description: |
> + phandle of battery characteristics node.
> + The charger uses the following properties:
> + - charge-term-current-microamp
> + - constant-charge-current-max-microamp
> + - voltage-max-design-microvolt
> + The constant-charge-current-max-microamp and voltage-max-design-microvolt
> + properties must be set.
> + See Documentation/devicetree/bindings/power/supply/battery.yaml
> +
> + interrupts:
> + items:
> + - description: Charger error
> + - description: Charger inhibited
> + - description: Charger precharge safety timer timeout
> + - description: Charger charge safety timer timeout
> + - description: Charger pre to fast charging switch threshold reached
> + - description: Charger recharge threshold reached
> + - description: Charger taper threshold reached
> + - description: Charger charge termination threshold reached
> + - description: Battery hot
> + - description: Battery warm
> + - description: Battery cold
> + - description: Battery cool
> + - description: Battery overvoltage
> + - description: Battery low
> + - description: Battery missing
> + - description: Battery thermistor missing # unconfirmed
> + - description: USB input undervolt
> + - description: USB input overvolt
> + - description: USB input source detected
> + - description: OTG regulator failure
> + - description: OTG regulator overcurrent
> + - description: Automatic input current limiting done
> + - description: USB ID pin changed
> + - description: DC input undervolt
> + - description: DC input overvolt
> + - description: Power OK
> + - description: Temperature shutdown
> + - description: Watchdog timeout
> + - description: Flash failure
> + - description: OTST2 # unknown
> + - description: OTST3 # unknown
It seems you listed register interrupts, not physical pins. This should
be interrupt lines.
Best regards,
Krzysztof
Powered by blists - more mailing lists