linux-kernel - Re: [PATCH] irqchip/loongson-pch-pic: Move find_pch_pic() into CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 08 Aug 2022 10:05:23 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Huacai Chen <chenhuacai@...ngson.cn>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Huacai Chen <chenhuacai@...il.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] irqchip/loongson-pch-pic: Move find_pch_pic() into
 CONFIG_ACPI

On 2022-08-08 09:53, Huacai Chen wrote:
> MIPS doesn't declare find_pch_pic(), which makes a build warning:
> 
>>> drivers/irqchip/irq-loongson-pch-pic.c:51:5: warning: no previous 
>>> prototype for function 'find_pch_pic' [-Wmissing-prototypes]
>    int find_pch_pic(u32 gsi)
>        ^
>    drivers/irqchip/irq-loongson-pch-pic.c:51:1: note: declare 'static'
> if the function is not intended to be used outside of this translation
> unit
>    int find_pch_pic(u32 gsi)
>    ^
>    static
>    1 warning generated.
> 
> Move find_pch_pic() into CONFIG_ACPI which only used by LoongArch to 
> fix
> the warning.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>  drivers/irqchip/irq-loongson-pch-pic.c | 38 +++++++++++++-------------
>  1 file changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-loongson-pch-pic.c
> b/drivers/irqchip/irq-loongson-pch-pic.c
> index b6f1392964b1..b987b6517d59 100644
> --- a/drivers/irqchip/irq-loongson-pch-pic.c
> +++ b/drivers/irqchip/irq-loongson-pch-pic.c
> @@ -48,25 +48,6 @@ static struct pch_pic *pch_pic_priv[MAX_IO_PICS];
> 
>  struct fwnode_handle *pch_pic_handle[MAX_IO_PICS];
> 
> -int find_pch_pic(u32 gsi)
> -{
> -	int i;
> -
> -	/* Find the PCH_PIC that manages this GSI. */
> -	for (i = 0; i < MAX_IO_PICS; i++) {
> -		struct pch_pic *priv = pch_pic_priv[i];
> -
> -		if (!priv)
> -			return -1;
> -
> -		if (gsi >= priv->gsi_base && gsi < (priv->gsi_base + 
> priv->vec_count))
> -			return i;
> -	}
> -
> -	pr_err("ERROR: Unable to locate PCH_PIC for GSI %d\n", gsi);
> -	return -1;
> -}
> -
>  static void pch_pic_bitset(struct pch_pic *priv, int offset, int bit)
>  {
>  	u32 reg;
> @@ -325,6 +306,25 @@ IRQCHIP_DECLARE(pch_pic, "loongson,pch-pic-1.0",
> pch_pic_of_init);
>  #endif
> 
>  #ifdef CONFIG_ACPI
> +int find_pch_pic(u32 gsi)
> +{
> +	int i;
> +
> +	/* Find the PCH_PIC that manages this GSI. */
> +	for (i = 0; i < MAX_IO_PICS; i++) {
> +		struct pch_pic *priv = pch_pic_priv[i];
> +
> +		if (!priv)
> +			return -1;
> +
> +		if (gsi >= priv->gsi_base && gsi < (priv->gsi_base + 
> priv->vec_count))
> +			return i;
> +	}
> +
> +	pr_err("ERROR: Unable to locate PCH_PIC for GSI %d\n", gsi);
> +	return -1;
> +}
> +
>  static int __init
>  pch_lpc_parse_madt(union acpi_subtable_headers *header,
>  		       const unsigned long end)

While you're fixing this, can you also please fix this:

$ git grep find_pch_pic
arch/loongarch/include/asm/irq.h:extern int find_pch_pic(u32 gsi);
arch/loongarch/include/asm/irq.h:int find_pch_pic(u32 gsi);

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...