[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 8 Aug 2022 11:33:37 +0200
From: Robert Foss <robert.foss@...aro.org>
To: Zeng Jingxiang <zengjx95@...il.com>
Cc: andrzej.hajda@...el.com, narmstrong@...libre.com,
Laurent.pinchart@...asonboard.com, jonas@...boo.se,
jernej.skrabec@...il.com, airlied@...ux.ie, daniel@...ll.ch,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Zeng Jingxiang <linuszeng@...cent.com>
Subject: Re: [PATCH] gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init()
On Wed, 27 Jul 2022 at 09:31, Zeng Jingxiang <zengjx95@...il.com> wrote:
>
> From: Zeng Jingxiang <linuszeng@...cent.com>
>
> A NULL check for bridge->encoder shows that it may be NULL, but it
> already been dereferenced on all paths leading to the check.
> 812 if (!bridge->encoder) {
>
> Dereference the pointer bridge->encoder.
> 810 drm_connector_attach_encoder(<9611->connector, bridge->encoder);
>
> Signed-off-by: Zeng Jingxiang <linuszeng@...cent.com>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index 7ef8fe5abc12..81a4751573fa 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -807,13 +807,14 @@ static int lt9611_connector_init(struct drm_bridge *bridge, struct lt9611 *lt961
>
> drm_connector_helper_add(<9611->connector,
> <9611_bridge_connector_helper_funcs);
> - drm_connector_attach_encoder(<9611->connector, bridge->encoder);
>
> if (!bridge->encoder) {
> DRM_ERROR("Parent encoder object not found");
> return -ENODEV;
> }
>
> + drm_connector_attach_encoder(<9611->connector, bridge->encoder);
> +
> return 0;
> }
>
> --
> 2.27.0
>
Applied to drm-misc-next.
Powered by blists - more mailing lists