linux-kernel - Re: [PATCH v5 27/33] hwmon/drivers/core: Switch to new of thermal API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Aug 2022 03:27:58 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Daniel Lezcano <daniel.lezcano@...exp.org>
Cc:     daniel.lezcano@...aro.org, rafael@...nel.org, rui.zhang@...el.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        khilman@...libre.com, abailon@...libre.com, lukasz.luba@....com,
        broonie@...nel.org, damien.lemoal@...nsource.wdc.com,
        heiko@...ech.de, hayashi.kunihiko@...ionext.com,
        mhiramat@...nel.org, talel@...zon.com, thierry.reding@...il.com,
        digetx@...il.com, jonathanh@...dia.com, anarsoul@...il.com,
        tiny.windzz@...il.com, baolin.wang7@...il.com,
        f.fainelli@...il.com, bjorn.andersson@...aro.org,
        mcoquelin.stm32@...il.com, glaroque@...libre.com,
        miquel.raynal@...tlin.com, shawnguo@...nel.org,
        niklas.soderlund@...natech.se, matthias.bgg@...il.com,
        j-keerthy@...com, Jean Delvare <jdelvare@...e.com>,
        "open list:HARDWARE MONITORING" <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH v5 27/33] hwmon/drivers/core: Switch to new of thermal API

On Fri, Aug 05, 2022 at 12:43:43AM +0200, Daniel Lezcano wrote:
> The thermal OF code has a new API allowing to migrate the OF
> initialization to a simpler approach. The ops are no longer device
> tree specific and are the generic ones provided by the core code.
> 
> Convert the ops to the thermal_zone_device_ops format and use the new
> API to register the thermal zone with these generic ops.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...exp.org>
> Acked-by: Guenter Roeck <linux@...ck-us.net>

Based on other feedback, it apears that with this patch in place the
hwmon device fails to register unless it is indeed part of a configured
thermal zone (which so far was optional). Given that, I have to withdraw
my Acked-by: tag until this problem has been resolved.

Guenter