lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 Aug 2022 13:12:25 +0200 From: Ondřej Jirman <megi@....cz> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Cc: Tom Fitzhenry <tom@...-fitzhenry.me.uk>, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, heiko@...ech.de, martijn@...xit.nl, ayufan@...fan.eu, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Hello, On Mon, Aug 08, 2022 at 09:35:55AM +0300, Krzysztof Kozlowski wrote: > On 06/08/2022 01:44, Tom Fitzhenry wrote: > > [...] > > > + > > + /* Power tree */ > > + /* Root power source */ > > + vcc_sysin: vcc-sysin { > > regulator-vcc-sysin Interestingly, most DTS files in rockchip/ use a -regulator suffix and none use regulator- prefix. And this is inconsistent across the larger DTS tree, because outside of rockchip/ most DTS use a prefix. Checked by grep -R 'regulator.*{' | grep -v state-me regards, o. > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc_sysin"; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + > > + /* Main 3.3v supply */ > > + vcc3v3_sys: wifi_bat: vcc3v3-sys { > > regulator-..... > > > + compatible = "regulator-fixed"; > > + regulator-name = "vcc3v3_sys"; > > + regulator-always-on; > > + regulator-boot-on; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + vin-supply = <&vcc_sysin>; > > + }; > > + > > + vcca1v8_s3: vcc1v8-s3 { > > regulator-..... > > > + compatible = "regulator-fixed"; > > + regulator-name = "vcca1v8_s3"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + vin-supply = <&vcc3v3_sys>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > +}; > > + > Best regards, > Krzysztof
Powered by blists - more mailing lists