lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 Aug 2022 14:25:34 +0200 From: Noralf Trønnes <noralf@...nnes.org> To: Maxime Ripard <maxime@...no.tech>, Jernej Skrabec <jernej.skrabec@...il.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Chen-Yu Tsai <wens@...e.org>, Philipp Zabel <p.zabel@...gutronix.de>, Jerome Brunet <jbrunet@...libre.com>, Samuel Holland <samuel@...lland.org>, Thomas Zimmermann <tzimmermann@...e.de>, Daniel Vetter <daniel@...ll.ch>, Emma Anholt <emma@...olt.net>, David Airlie <airlied@...ux.ie>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Kevin Hilman <khilman@...libre.com>, Neil Armstrong <narmstrong@...libre.com>, Maxime Ripard <mripard@...nel.org> Cc: linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org, Phil Elwell <phil@...pberrypi.com>, Mateusz Kwiatkowski <kfyatek+publicgit@...il.com>, linux-arm-kernel@...ts.infradead.org, Geert Uytterhoeven <geert@...ux-m68k.org>, Dave Stevenson <dave.stevenson@...pberrypi.com>, linux-amlogic@...ts.infradead.org, dri-devel@...ts.freedesktop.org, Dom Cobley <dom@...pberrypi.com> Subject: Re: [PATCH v1 01/35] drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity Den 29.07.2022 18.34, skrev Maxime Ripard: > We currently have two sets of TV properties. > > The first one is there to deal with analog TV properties, creating > properties such as the TV mode, subconnectors, saturation, hue and so on. > It's created by calling the drm_mode_create_tv_properties() function. > > The second one is there to deal with properties that might be useful on a > TV, creating the overscan margins for example. It's created by calling the > drm_mode_create_tv_margin_properties(). > > However, we also have a drm_atomic_helper_connector_tv_reset() function > that will reset the TV margin properties to their default values, and thus > is supposed to be called for the latter set. This creates an ambiguity due > to the inconsistent naming. > > We can thus rename the drm_atomic_helper_connector_tv_reset() function to > drm_atomic_helper_connector_tv_margins_reset() to remove that ambiguity > and hopefully make it more obvious. > > Signed-off-by: Maxime Ripard <maxime@...no.tech> > Reviewed-by: Noralf Trønnes <noralf@...nnes.org>
Powered by blists - more mailing lists