linux-kernel - Re: [GIT PULL] USB / Thunderbolt driver changes for 6.0-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Aug 2022 15:07:00 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Andrey Strachuk <strochuk@...ras.ru>
Subject: Re: [GIT PULL] USB / Thunderbolt driver changes for 6.0-rc1

On Wed, Aug 03, 2022 at 09:26:55PM +0530, Krishna Kurapati PSSNV wrote:
> 
> On 8/3/2022 9:20 PM, Greg KH wrote:
> > On Wed, Aug 03, 2022 at 08:43:49AM -0700, Nathan Chancellor wrote:
> > > On Wed, Aug 03, 2022 at 04:10:26PM +0200, Greg KH wrote:
> > > > Andrey Strachuk (1):
> > > >        usb: cdns3: change place of 'priv_ep' assignment in cdns3_gadget_ep_dequeue(), cdns3_gadget_ep_enable()
> > > For the record, this breaks allmodconfig with clang (I haven't seen a
> > > formal report on it anywhere and this missed -next coverage because
> > > Stephen is on vacation):
> > > 
> > >      drivers/usb/cdns3/cdns3-gadget.c:2290:11: error: variable 'priv_dev' is uninitialized when used here [-Werror,-Wuninitialized]
> > >                      dev_dbg(priv_dev->dev, "usbss: invalid parameters\n");
> > >                              ^~~~~~~~
> > >      include/linux/dev_printk.h:155:18: note: expanded from macro 'dev_dbg'
> > >              dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> > >                              ^~~
> > >      include/linux/dynamic_debug.h:167:7: note: expanded from macro 'dynamic_dev_dbg'
> > >                              dev, fmt, ##__VA_ARGS__)
> > >                              ^~~
> > >      include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
> > >              __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
> > >                                                                  ^~~~~~~~~~~
> > >      include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
> > >                      func(&id, ##__VA_ARGS__);               \
> > >                                  ^~~~~~~~~~~
> > >      drivers/usb/cdns3/cdns3-gadget.c:2278:31: note: initialize the variable 'priv_dev' to silence this warning
> > >              struct cdns3_device *priv_dev;
> > >                                          ^
> > >                                          = NULL
> > >      1 error generated.
> > > 
> > > I know you don't take patches during the merge window, so I guess we'll
> > > just have to have x86_64 allmodconfig be broken with clang for -rc1? :/
> > I can send fix-up patches that break the build before -rc1 if you have
> > it.  Also you can send it and Linus can pick it up directly if it breaks
> > his workflow.
> > 
> > Odd that this was never reported, 0-day didn't even say anything?
> > 
> > thanks,
> > 
> > greg k-h
> Hi Greg,
>   On a similar note. There was another issue reported in which randconfig
> for i386 build breaks as usb_hub_find_child API is not present as usbcore
> isn't compiled in that config (CONFIG_USB isn't set).
> Patch to fix has been pushed recently and is in review:
> https://lore.kernel.org/linux-usb/1659337215-20421-1-git-send-email-quic_kriskura@quicinc.com/
> 
> Would it be possible to pick it up in rc1 to make sure nothing breaks
> further because of it.
> I can respin patch if something is off in it.

See my comments to that patch, and Johan's attempt at it.  Something
larger is broken here, let's not paper over the issue right now with a
#ifdef in the .c file.  Fix it properly for 6.0-final.  Builds without
CONFIG_USB and gadget-only mode enabled are rare but this can be fixed
up after -rc1 is out, no rush right now.

thanks,

greg k-h