[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 8 Aug 2022 16:18:09 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Francesco Dolcini <francesco.dolcini@...adex.com>
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, Ahmad Fatoum <a.fatoum@...gutronix.de>,
Lee Jones <lee@...nel.org>
Subject: Re: [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible
On Tue, 12 Jul 2022, Francesco Dolcini wrote:
> Use sub-function of_compatible during probe, instead of using the node
> name. The code should not rely on the node names during probe, in
> addition to that the previously hard-coded node names are not compliant
> to the latest naming convention (they are not generic and they use
> underscores), and it was broken by mistake already once [1].
>
> [1] commit 56086b5e804f ("ARM: dts: imx6qdl-apalis: Avoid underscore in node name")
>
> Suggested-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---
> v2:
> - remove define usage for compatible strings
> - moved rotator removal from probe to a separate patch
> ---
> drivers/mfd/stmpe.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Applied, thanks.
--
DEPRECATED: Please use lee@...nel.org
Powered by blists - more mailing lists