[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 8 Aug 2022 16:20:12 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Andy Shevchenko <andy@...nel.org>,
Lee Jones <lee@...nel.org>
Subject: Re: [RESEND][PATCH v1 8/9] mfd: intel_soc_pmic_bxtwc: Support IRQ
chip hierarchy
On Mon, 18 Jul 2022, Andy Shevchenko wrote:
No commit message.
Probably needs to justify why it's calling a function denoted for
internal use only.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/mfd/intel_soc_pmic_bxtwc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c
> index 8dac0d41f64f..f9842ff44b3f 100644
> --- a/drivers/mfd/intel_soc_pmic_bxtwc.c
> +++ b/drivers/mfd/intel_soc_pmic_bxtwc.c
> @@ -422,8 +422,10 @@ static int bxtwc_add_chained_irq_chip(struct intel_soc_pmic *pmic,
> return dev_err_probe(pmic->dev, irq, "Failed to get parent vIRQ(%d) for chip %s\n",
> pirq, chip->name);
>
> - return devm_regmap_add_irq_chip(pmic->dev, pmic->regmap, irq, irq_flags,
> - 0, chip, data);
> + return __devm_regmap_add_irq_chip(pmic->dev, pmic->regmap, irq,
> + irq_flags, 0,
> + regmap_irq_get_domain(pdata),
> + chip, data);
> }
>
> static int bxtwc_probe(struct platform_device *pdev)
--
DEPRECATED: Please use lee@...nel.org
Powered by blists - more mailing lists