linux-kernel - Re: [PATCH] watchdog: Remove redundant word in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Aug 2022 08:49:01 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     shaomin Deng <dengshaomin@...rlc.com>, wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: Remove redundant word in comments

On 8/8/22 08:39, shaomin Deng wrote:
> There is a rebundant word "we" in comments, so remove it.
> 
> Signed-off-by: shaomin Deng <dengshaomin@...rlc.com>

I really wish there was a rule against such cosmetic changes. People
don't realize how much maintainer time is involved in reviewing and
applying that stuff.

Oh well.

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/eurotechwdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/eurotechwdt.c b/drivers/watchdog/eurotechwdt.c
> index ce682942662c..e26609ad4c17 100644
> --- a/drivers/watchdog/eurotechwdt.c
> +++ b/drivers/watchdog/eurotechwdt.c
> @@ -192,7 +192,7 @@ static void eurwdt_ping(void)
>    * @ppos: pointer to the position to write. No seeks allowed
>    *
>    * A write to a watchdog device is defined as a keepalive signal. Any
> - * write of data will do, as we we don't define content meaning.
> + * write of data will do, as we don't define content meaning.
>    */
>   
>   static ssize_t eurwdt_write(struct file *file, const char __user *buf,