[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 8 Aug 2022 09:55:54 -0600
From: Rob Herring <robh@...nel.org>
To: Markuss Broks <markuss.broks@...il.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>, Andy
Shevchenko <andy.shevchenko@...il.com>,"
<~postmarketos/upstreaming@...ts.sr.ht>,
phone-devel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
Ard Biesheuvel <ardb@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>,
Helge Deller <deller@....de>,
"Paul E. McKenney" <paulmck@...nel.org>,
Borislav Petkov <bp@...e.de>,
Kees Cook <keescook@...omium.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Randy Dunlap <rdunlap@...radead.org>,
Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
Michal Suchanek <msuchanek@...e.de>,
Javier Martinez Canillas <javierm@...hat.com>,
Arnd Bergmann <arnd@...db.de>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Wei Ming Chen <jj251510319013@...il.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Tony Lindgren <tony@...mide.com>,
Linux Doc Mailing List <linux-doc@...r.kernel.org>,
linux-efi <linux-efi@...r.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name
On Sat, Aug 6, 2022 at 10:34 AM Markuss Broks <markuss.broks@...il.com> wrote:
>
> The "node" argument is actually an offset,
It's an offset to a node in the FDT. The fact that it is an offset is
an internal implementation detail of the FDT format. So really, it's a
handle to a node. 'node' is more descriptive to its purpose.
> and it's also an "int", and not "unsigned long".
Uh, no it's not. of_flat_dt_*() functions all take an unsigned long.
Rob
Powered by blists - more mailing lists