[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 8 Aug 2022 17:13:26 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Hans de Goede <hdegoede@...hat.com>, linux-kernel@...r.kernel.org,
Lee Jones <lee@...nel.org>, Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v3 07/10] mfd: intel_soc_pmic_crc: Drop redundant
ACPI_PTR() and ifdeffery
On Mon, 01 Aug 2022, Andy Shevchenko wrote:
> The driver depends on ACPI, ACPI_PTR() resolution is always the same.
> Otherwise a compiler may produce a warning.
>
> That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or
> none should be used in a driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Tested-by: Hans de Goede <hdegoede@...hat.com>
> Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> ---
>
> v3: no changes
> v2: added tags and rebased on top of new patch 1
>
> drivers/mfd/Kconfig | 4 ++--
> drivers/mfd/intel_soc_pmic_crc.c | 6 ++----
> 2 files changed, 4 insertions(+), 6 deletions(-)
Applied, thanks.
--
DEPRECATED: Please use lee@...nel.org
Powered by blists - more mailing lists