linux-kernel - Re: [PATCH 2/3] spi: stm32_qspi: Add transfer_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Aug 2022 17:15:28 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Patrice CHOTARD <patrice.chotard@...s.st.com>
Cc:     Alexandre Torgue <alexandre.torgue@...s.st.com>,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-spi@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        christophe.kerello@...s.st.com, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/3] spi: stm32_qspi: Add transfer_one_message() spi
 callback

On Mon, Aug 08, 2022 at 06:09:51PM +0200, Patrice CHOTARD wrote:
> On 8/8/22 15:29, Mark Brown wrote:
> > On Mon, Aug 08, 2022 at 09:40:50AM +0200, patrice.chotard@...s.st.com wrote:

> >> +	ret = pm_runtime_get_sync(qspi->dev);
> >> +	if (ret < 0) {
> >> +		pm_runtime_put_noidle(qspi->dev);
> >> +		return ret;
> >> +	}

> > Use the core runtime PM, there should be no need to open code.

> Right, i will use pm_runtime_resume_and_get() instead.

There's also core SPI support for calling this - set auto_runtime_pm.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)