linux-kernel - Re: [PATCH 3/3] ASoC: apple: mca: Add locks on foreign cluster access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D63678FD-92EB-42E1-B04F-CCA563F4596A@cutebit.org>
Date:   Tue, 9 Aug 2022 09:12:37 +0200
From:   Martin Povišer <povik+lin@...ebit.org>
To:     Martin Povišer <povik+lin@...ebit.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     asahi@...ts.linux.dev, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ASoC: apple: mca: Add locks on foreign cluster access


> @@ -331,8 +339,10 @@ static int mca_be_prepare(struct snd_pcm_substream *substream,
> 	 */
> 	if (!mca_fe_clocks_in_use(fe_cl)) {
> 		ret = mca_fe_enable_clocks(fe_cl);
> -		if (ret < 0)
> +		if (ret < 0) {
> +			mutex_unlock(&mca->port_mutex);
> 			return ret;
> +		}
> 	}

Stray unlock here

--
Martin