linux-kernel - Re: [PATCH v5 1/2] fpga: ecp5-spi: add Lattice ECP5 FPGA manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220809065431.nbfopsvx6teja37i@x260>
Date:   Tue, 9 Aug 2022 09:54:31 +0300
From:   Ivan Bornyakov <i.bornyakov@...rotek.ru>
To:     Daniel Glöckner <dg@...ix.com>
Cc:     mdf@...nel.org, hao.wu@...el.com, yilun.xu@...el.com,
        trix@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-fpga@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        system@...rotek.ru
Subject: Re: [PATCH v5 1/2] fpga: ecp5-spi: add Lattice ECP5 FPGA manager

On Mon, Aug 01, 2022 at 09:24:49AM +0200, Daniel Glöckner wrote:
> Hi,
> 
> On Tue, Jul 19, 2022 at 02:23:34PM +0300, Ivan Bornyakov wrote:
> > +	/* Enter init mode */
> > +	gpiod_set_value(priv->program, 1);
> > +
> > +	ret = ecp5_poll_gpio(priv->init, true);
> > +	if (!ret)
> > +		ret = ecp5_poll_gpio(priv->done, false);
> > +
> > +	if (ret) {
> > +		dev_err(dev, "Failed to go to initialization mode\n");
> > +		return ret;
> > +	}
> 
> To me the documentation looks like the chip will deassert INITN after
> tINITL regardless of the PROGRAMN signal. At 55ns max tINITL is too
> short to reliably sample INITN while it is asserted when we have
> interrupts enabled. Can you confirm that INITN stays asserted as long
> as PROGRAMN is asserted?

I confirm that INITN stays asserted while PROGRAMN is asserted, just
rechecked.