linux-kernel - Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvIPf/m3hU46S9Ik@zn.tnic>
Date:   Tue, 9 Aug 2022 09:40:47 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Kani, Toshi" <toshi.kani@....com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Jia He <justin.he@....com>, Len Brown <lenb@...nel.org>,
        James Morse <james.morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>
Subject: Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv
 register

On Mon, Aug 08, 2022 at 09:36:13PM +0000, Kani, Toshi wrote:
> Platforms with ACPI GHES support should use ghes_edac. This is the
> case on Arm. The x86 side has additional platform ID check to protect
> from legacy buggy GHES FW existed before ghes_edac enablement.

Sounds to me like we should put all that logic in ghes.c and out of
ghes_edac and the EDAC drivers will query it by doing upon load:

<edac_driver>_init:

	if (ghes_edac_driver_is_preferred())
		return -ENODEV;

And then ghes_edac can become a normal driver module again.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette