linux-kernel - Re: soundwire qcom slimbus dependency (was Re: [PATCH 0/2] arm64 defconfig: Get faddr2line working)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Aug 2022 09:28:51 +0100
From:   John Garry <john.garry@...wei.com>
To:     Arnd Bergmann <arnd@...db.de>, Jonathan Marek <jonathan@...ek.ca>
CC:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Olof Johansson <olof@...om.net>, "SoC Team" <soc@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: soundwire qcom slimbus dependency (was Re: [PATCH 0/2] arm64
 defconfig: Get faddr2line working)

On 04/08/2022 11:35, John Garry wrote:
>>>>           ctrl->cols_index = sdw_find_col_index(data->default_cols);
>>>> -#if IS_REACHABLE(CONFIG_SLIMBUS)
>>>> -       if (dev->parent->bus == &slimbus_bus) {
>>>> -#else
>>>> -       if (false) {
>>>> -#endif
>>>> +       if (IS_ENABLED(CONFIG_SLIMBUS) && dev->parent->bus == 
>>>> &slimbus_bus) {
>>>>                   ctrl->reg_read = qcom_swrm_ahb_reg_read;
>>>>                   ctrl->reg_write = qcom_swrm_ahb_reg_write;
>>>>                   ctrl->regmap = dev_get_regmap(dev->parent, NULL);
>>>>
>>>
>>> This relies on the compiler optimizing out the reference to slimbus_bus,
>>> which doesn't exist in the CONFIG_SLIMBUS=n case (not tested, but I
>>> think this means an O0 build will fail?).
>>
>> That is correct: We rely on this everywhere in the kernel, which is why
>> it is impossible to build kernels with -O0.
>>
> 
> Was there any patch sent to fix/improve this? I could not see any. Or 
> any plan to do so?

Since I got no response, I'll assume 'no'. So I'll look to do this when 
I get a chance.

Thanks,
John