linux-kernel - Re: [PATCH] Revert "reset: microchip-sparx5: allow building as a module"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c86be0e45807b86aff394026e015253@walle.cc>
Date:   Tue, 09 Aug 2022 12:27:27 +0200
From:   Michael Walle <michael@...le.cc>
To:     Steen Hegelund <steen.hegelund@...rochip.com>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Clément Léger <clement.leger@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH] Revert "reset: microchip-sparx5: allow building as a
 module"

Hi Steen,

Am 2022-08-09 12:19, schrieb Steen Hegelund:
> Sorry, but most people have been OOO (including me), so this has
> delayed the response.
> 
> The protection bit protects the VCore Shared Bus (SBA) blocks shown on
> Figure 5-1. VCore System
> Block Diagram in the Datasheet.  So in this case also the watchdog
> (which is the WDT block).
> 
> I hope this clarifies the usage.

Actually, it does not. The watchdog was just an example. I'm
questioning the use of this reset for the switch block. Esp.
as it turns out that not even microchip knows what blocks
are actually reset.

This reset was first introduced for the DSA switch, since then
more and more spurious errors were discovered and it turns out
all of these errors was because the "switch" reset had some
severe side effects, like resetting the GPIO core and thus
turning all the GPIOs to input mode which then took some
peripherals into reset.

-michael