linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220809142139.GA2105857@roeck-us.net>
Date:   Tue, 9 Aug 2022 07:21:39 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Robert Marko <robert.marko@...tura.hr>
Cc:     jdelvare@...e.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, lars.povlsen@...rochip.com,
        Steen.Hegelund@...rochip.com, UNGLinuxDriver@...rochip.com,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        luka.perkov@...tura.hr
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock

On Tue, Aug 09, 2022 at 01:22:08PM +0200, Robert Marko wrote:
> SparX-5 temperature sensor uses system reference clock and not the AHB bus
> clock as indicated by the register information [1].
> 
> So, correct the clock description as well the included example.
> 
> [1] https://microchip-ung.github.io/sparx-5_reginfo/reginfo_sparx-5.html?select=hsiowrap,temp_sensor,temp_sensor_cfg,clk_cycles_1us
> 
> Fixes: f5520753c16f ("dt-bindings: hwmon: Add Sparx5 temperature sensor")
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/microchip,sparx5-temp.yaml      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> index 76be625d5646..51e8619dbf3c 100644
> --- a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> @@ -22,7 +22,7 @@ properties:
>  
>    clocks:
>      items:
> -      - description: AHB reference clock
> +      - description: System reference clock
>  
>    '#thermal-sensor-cells':
>      const: 0
> @@ -40,5 +40,5 @@ examples:
>          compatible = "microchip,sparx5-temp";
>          reg = <0x10508110 0xc>;
>          #thermal-sensor-cells = <0>;
> -        clocks = <&ahb_clk>;
> +        clocks = <&sys_clk>;
>      };