linux-kernel - Re: [PATCH] sched/fair: Introduce priority load balance to reduce interference from IDLE tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Aug 2022 00:14:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     zhangsong <zhangsong34@...wei.com>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org
Cc:     kbuild-all@...ts.01.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, vschneid@...hat.com,
        linux-kernel@...r.kernel.org, zhangsong <zhangsong34@...wei.com>
Subject: Re: [PATCH] sched/fair: Introduce priority load balance to reduce
 interference from IDLE tasks

Hi zhangsong,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on linus/master v5.19 next-20220809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/zhangsong/sched-fair-Introduce-priority-load-balance-to-reduce-interference-from-IDLE-tasks/20220809-213204
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 8648f92a66a323ed01903d2cbb248cdbe2f312d9
config: um-x86_64_defconfig (https://download.01.org/0day-ci/archive/20220810/202208100012.psioE872-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/20ac252fc4280e5b1a45070d722c7edc0695088b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review zhangsong/sched-fair-Introduce-priority-load-balance-to-reduce-interference-from-IDLE-tasks/20220809-213204
        git checkout 20ac252fc4280e5b1a45070d722c7edc0695088b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=um SUBARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c:672:5: warning: no previous prototype for 'sched_update_scaling' [-Wmissing-prototypes]
     672 | int sched_update_scaling(void)
         |     ^~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c: In function 'adjust_rq_cfs_tasks':
>> kernel/sched/fair.c:3045:48: error: 'struct rq' has no member named 'cfs_idle_tasks'
    3045 |                 (*list_op)(&se->group_node, &rq->cfs_idle_tasks);
         |                                                ^~
>> kernel/sched/fair.c:3047:48: error: 'struct rq' has no member named 'cfs_tasks'
    3047 |                 (*list_op)(&se->group_node, &rq->cfs_tasks);
         |                                                ^~
   At top level:
   kernel/sched/fair.c:3038:1: warning: 'adjust_rq_cfs_tasks' defined but not used [-Wunused-function]
    3038 | adjust_rq_cfs_tasks(void (*list_op)(struct list_head *, struct list_head *),
         | ^~~~~~~~~~~~~~~~~~~


vim +3045 kernel/sched/fair.c

  3036	
  3037	static void
  3038	adjust_rq_cfs_tasks(void (*list_op)(struct list_head *, struct list_head *),
  3039		struct rq *rq,
  3040		struct sched_entity *se)
  3041	{
  3042		struct cfs_rq *cfs_rq = cfs_rq_of(se);
  3043	
  3044		if (task_has_idle_policy(task_of(se)) || tg_is_idle(cfs_rq->tg))
> 3045			(*list_op)(&se->group_node, &rq->cfs_idle_tasks);
  3046		else
> 3047			(*list_op)(&se->group_node, &rq->cfs_tasks);
  3048	}
  3049	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp