linux-kernel - Re: [PATCH] selftests: add missing ')' in lib.mk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Aug 2022 09:36:12 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Guillaume Tucker <guillaume.tucker@...labora.com>
Cc:     Shuah Khan <shuah@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, Mark Brown <broonie@...nel.org>,
        kernel@...labora.com, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] selftests: add missing ')' in lib.mk

On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote:
> Add missing closing ')' in lib.mk in a call to $error().  This only
> affects LLVM / Clang builds.
> 
> Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
> Signed-off-by: Guillaume Tucker <guillaume.tucker@...labora.com>

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  tools/testing/selftests/lib.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 947fc72413e9..a87f60873e5b 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS              := $(CLANG_TARGET_FLAGS_$(ARCH))
>  
>  ifeq ($(CROSS_COMPILE),)
>  ifeq ($(CLANG_TARGET_FLAGS),)
> -$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk
> +$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk)
>  else
>  CLANG_FLAGS     += --target=$(CLANG_TARGET_FLAGS)
>  endif # CLANG_TARGET_FLAGS
> -- 
> 2.30.2
>