linux-kernel - Re: [PATCH 1/4] dt-bindings: arm: fsl: imx6ul-kontron: Update bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1af9295f-3b50-bd7e-bd60-429de7fcc308@kontron.de>
Date:   Tue, 9 Aug 2022 18:34:42 +0200
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Frieder Schrempf <frieder@...s.de>, devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, Li Yang <leoyang.li@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>
Cc:     Alexander Stein <alexander.stein@...tq-group.com>,
        Denys Drozdov <denys.drozdov@...adex.com>,
        Fabio Estevam <festevam@...x.de>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Marek Vasut <marex@...x.de>,
        Matthias Schiffer <matthias.schiffer@...group.com>,
        Max Krummenacher <max.krummenacher@...adex.com>,
        Rob Herring <robh@...nel.org>,
        Tim Harvey <tharvey@...eworks.com>
Subject: Re: [PATCH 1/4] dt-bindings: arm: fsl: imx6ul-kontron: Update
 bindings

Am 09.08.22 um 17:55 schrieb Krzysztof Kozlowski:
> On 09/08/2022 18:25, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>>
>> This updates the bindings in order to simplify the devicetree
>> structure and to add names for the boards that follow the latest
>> convention used by Kontron marketing.
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
>> ---
>>  .../devicetree/bindings/arm/fsl.yaml          | 31 +++++++------------
>>  1 file changed, 12 insertions(+), 19 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index ef524378d449..7c4c27d553ec 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -553,8 +553,7 @@ properties:
>>                - engicam,imx6ul-isiot      # Engicam Is.IoT MX6UL eMMC/NAND Starter kit
>>                - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
>>                - karo,imx6ul-tx6ul         # Ka-Ro electronics TXUL-0010 Module
>> -              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
>> -              - kontron,imx6ul-n6311-som  # Kontron N6311 SOM
>> +              - kontron,imx6ul-n631x-som  # Kontron SL i.MX6UL (N631X SOM)
> 
> Although board-level compatibles are not that important, yet still they
> follow the same rules as other DT bindings: no wildcards for compatibles.
> 
> Therefore the change is not correct, in my opinion.

Ok, I see your point. I will look for a way to get rid of the wildcard
in the compatible. Either by keeping the old names and having some
duplication in the devicetree files or by renaming the compatibles
altogether, as the N6xxx notation is not used nowadays anyway.