linux-kernel - Re: [PATCH] perf tools: Fix missing free of machine->kallsyms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fWx_evrzai1Q_6FsowHG-V2H5jX58-s5AetJJcG4C0+2g@mail.gmail.com>
Date:   Tue, 9 Aug 2022 09:51:12 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix missing free of machine->kallsyms_filename

On Tue, Aug 9, 2022 at 6:08 AM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> Add missing free of machine->kallsyms_filename to machine__exit().
>
> Fixes: a5367ecb5353 ("perf tools: Automatically use guest kcore_dir if present")
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/util/machine.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index facc13fbf16e..2a16cae28407 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -236,6 +236,7 @@ void machine__exit(struct machine *machine)
>         zfree(&machine->root_dir);
>         zfree(&machine->mmap_name);
>         zfree(&machine->current_tid);
> +       zfree(&machine->kallsyms_filename);
>
>         for (i = 0; i < THREADS__TABLE_SIZE; i++) {
>                 struct threads *threads = &machine->threads[i];
> --
> 2.25.1
>