linux-kernel - Re: [PATCH 1/3] hfs: Unmap the page in the "fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <79023F53-CAC5-4D88-B171-317B92A2EEE1@dubeyko.com>
Date:   Tue, 9 Aug 2022 11:05:03 -0700
From:   Viacheslav Dubeyko <slava@...eyko.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Jeff Layton <jlayton@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Muchun Song <songmuchun@...edance.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH 1/3] hfs: Unmap the page in the "fail_page" label



> On Aug 9, 2022, at 8:20 AM, Fabio M. De Francesco <fmdefrancesco@...il.com> wrote:
> 
> Several paths within hfs_btree_open() jump to the "fail_page" label
> where put_page() is called while the page is still mapped.
> 
> Call kunmap() to unmap the page soon before put_page().
> 
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> ---
> fs/hfs/btree.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/fs/hfs/btree.c b/fs/hfs/btree.c
> index 19017d296173..56c6782436e9 100644
> --- a/fs/hfs/btree.c
> +++ b/fs/hfs/btree.c
> @@ -124,6 +124,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke
> 	return tree;
> 
> fail_page:
> +	kunmap(page);
> 	put_page(page);
> free_inode:
> 	tree->inode->i_mapping->a_ops = &hfs_aops;
> -- 
> 2.37.1
> 


Looks good.

Reviewed-by: Viacheslav Dubeyko <slava@...eyko.com>

Thanks,
Slava.