linux-kernel - Re: [PATCH] crypto/drbg.c:remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Aug 2022 18:07:01 +0000
From:   Eric Biggers <ebiggers@...nel.org>
To:     Dong Chuanjian <chuanjian@...china.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...china.com
Subject: Re: [PATCH] crypto/drbg.c:remove unnecessary (void*) conversions

On Tue, Aug 09, 2022 at 05:14:52PM +0800, Dong Chuanjian wrote:
>  	struct crypto_cipher *tfm =
> -		(struct crypto_cipher *)drbg->priv_data;
> +		drbg->priv_data;

Might as well join this into one line.

>  
>  	crypto_cipher_setkey(tfm, key, (drbg_keylen(drbg)));
>  }
> @@ -1828,7 +1828,7 @@ static int drbg_kcapi_sym(struct drbg_state *drbg, unsigned char *outval,
>  			  const struct drbg_string *in)
>  {
>  	struct crypto_cipher *tfm =
> -		(struct crypto_cipher *)drbg->priv_data;
> +		drbg->priv_data;

Likewise.

- Eric