linux-kernel - Re: [PATCH] Fixes compilation errors after checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202208110717.w2MDXPcA-lkp@intel.com>
Date:   Thu, 11 Aug 2022 07:35:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Simone Serra <serrazimone@...il.com>, gregkh@...uxfoundation.org,
        fabioaiuto83@...il.com, soumya.negi97@...il.com,
        hdegoede@...hat.com, straube.linux@...il.com
Cc:     kbuild-all@...ts.01.org, Simone Serra <serrazimone@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixes compilation errors after checkpatch warnings

Hi Simone,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on linus/master next-20220810]
[cannot apply to v5.19]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Simone-Serra/Fixes-compilation-errors-after-checkpatch-warnings/20220809-223922
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 4e23eeebb2e57f5a28b36221aa776b5a1122dde5
config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220811/202208110717.w2MDXPcA-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/4178fe5425c24dfeabf5c4eb7fd13ada51d007c3
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Simone-Serra/Fixes-compilation-errors-after-checkpatch-warnings/20220809-223922
        git checkout 4178fe5425c24dfeabf5c4eb7fd13ada51d007c3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/staging/rtl8723bs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/rtl8723bs/core/rtw_btcoex.c:12:6: warning: no previous prototype for 'rtw_btcoex_MediaStatusNotify' [-Wmissing-prototypes]
      12 | void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/rtw_btcoex_MediaStatusNotify +12 drivers/staging/rtl8723bs/core/rtw_btcoex.c

554c0a3abf216c Hans de Goede 2017-03-29  11  
554c0a3abf216c Hans de Goede 2017-03-29 @12  void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
554c0a3abf216c Hans de Goede 2017-03-29  13  {
948d704855312c Shreeya Patel 2017-07-09  14  	if ((mediaStatus == RT_MEDIA_CONNECT)
554c0a3abf216c Hans de Goede 2017-03-29  15  		&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
554c0a3abf216c Hans de Goede 2017-03-29  16  		rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
554c0a3abf216c Hans de Goede 2017-03-29  17  	}
554c0a3abf216c Hans de Goede 2017-03-29  18  
554c0a3abf216c Hans de Goede 2017-03-29  19  	hal_btcoex_MediaStatusNotify(padapter, mediaStatus);
554c0a3abf216c Hans de Goede 2017-03-29  20  }
554c0a3abf216c Hans de Goede 2017-03-29  21  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp