linux-kernel - Re: [PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Aug 2022 10:08:36 +0530
From:   "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh@...nel.org>
CC:     Douglas Anderson <dianders@...omium.org>,
        Andy Gross <agross@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_tdas@...cinc.com>
Subject: Re: [PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node


On 8/9/2022 10:04 PM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-08-08 23:35:07)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 13d7f26..71735bb 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -2168,9 +2168,8 @@
>>                  lpasscc: lpasscc@...0000 {
>>                          compatible = "qcom,sc7280-lpasscc";
>>                          reg = <0 0x03000000 0 0x40>,
>> -                             <0 0x03c04000 0 0x4>,
>> -                             <0 0x03389000 0 0x24>;
>> -                       reg-names = "qdsp6ss", "top_cc", "cc";
>> +                                 <0 0x03c04000 0 0x4>;
> This looks oddly tabbed out? I'd expect it to align with the first reg
> property, so be unchanged.


Okay, I will correct the tabbing. But this wouldn't remain unchanged 
because the comma is being replaced by semi-colon.


>> +                       reg-names = "qdsp6ss", "top_cc";
>>                          clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
>>                          clock-names = "iface";