linux-kernel - Re: [PATCH v5 00/33] New thermal OF code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Aug 2022 02:56:07 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Michael Walle <michael@...le.cc>
Cc:     daniel.lezcano@...exp.org, abailon@...libre.com,
        anarsoul@...il.com, baolin.wang7@...il.com,
        bjorn.andersson@...aro.org, broonie@...nel.org,
        damien.lemoal@...nsource.wdc.com, digetx@...il.com,
        f.fainelli@...il.com, glaroque@...libre.com,
        hayashi.kunihiko@...ionext.com, heiko@...ech.de, j-keerthy@...com,
        jonathanh@...dia.com, khilman@...libre.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        lukasz.luba@....com, matthias.bgg@...il.com,
        mcoquelin.stm32@...il.com, mhiramat@...nel.org,
        miquel.raynal@...tlin.com, niklas.soderlund@...natech.se,
        rafael@...nel.org, rui.zhang@...el.com, shawnguo@...nel.org,
        talel@...zon.com, thierry.reding@...il.com, tiny.windzz@...il.com
Subject: Re: [PATCH v5 00/33] New thermal OF code

On 8/10/22 01:34, Daniel Lezcano wrote:
> 
> Hi Guenter,
> 
> On 08/08/2022 12:26, Guenter Roeck wrote:
>> On Mon, Aug 08, 2022 at 11:42:16AM +0200, Michael Walle wrote:
> 
> [ ... ]
> 
>> It would also mean that all hwmon drivers registering a thermal zone sensor
>> would fail to register unless such a thermal zone actually exists. This
>> would make the whole concept of having the hwmon core register thermal
>> zone sensors impossible. I have no idea how this is expected to work now,
>> but there is an apparent flaw in the logic. That means I withdraw my
>> Acked-by: for the hwmon patches in this series until it is guaranteed
>> that hwmon registration does not fail as above if there is no thermal
>> zone associated with a sensor.
> 
> I tried to figure out where we are not in sync and I suspect there is a misunderstanding from my side of your initial statement.
> 
> I understood you meant the thermal zone can not be created with the hwmon if there is no thermal zone description and that was the case before.
> 
> But actually, I suspect I misunderstood and you meant if the thermal OF registration fails, the hwmon creation fails for the hwmon subsystem, and before the changes it was created anyway.
> 
> Is that correct ?
> 

Yes, that is what I meant.

> If yes, the change -EINVAL --> -ENODEV fixes the issue, shall I consider in this case your Acked-by ?
> 
Yes.

Thanks,
Guenter

> Thanks
>    -- Daniel
>