linux-kernel - Re: [PATCH v5 02/20] dt-bindings: memory: mediatek: Update condition for mt8195 smi node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1238beb0a140a0987b8fdda6e7bbadfbb2415ed4.camel@mediatek.com>
Date:   Wed, 10 Aug 2022 09:51:32 +0800
From:   Tinghan Shen <tinghan.shen@...iatek.com>
To:     "Nícolas F. R. A. Prado" <nfraprado@...labora.com>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Yong Wu <yong.wu@...iatek.com>, Joerg Roedel <joro@...tes.org>,
        Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lee Jones <lee@...nel.org>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        MandyJH Liu <mandyjh.liu@...iatek.com>,
        <iommu@...ts.linux.dev>, <linux-mediatek@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v5 02/20] dt-bindings: memory: mediatek: Update
 condition for mt8195 smi node

On Tue, 2022-08-09 at 09:53 -0400, Nícolas F. R. A. Prado wrote:
> On Tue, Aug 09, 2022 at 07:01:10PM +0800, Tinghan Shen wrote:
> > Hi Krzysztof,
> > 
> > On Thu, 2022-08-04 at 17:12 +0200, Krzysztof Kozlowski wrote:
> > > On 04/08/2022 04:15, Tinghan Shen wrote:
> > > > 
> > > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly
> > > > matches the 'else' conditions for gen2 HW without gals.
> > > > 
> > > > Rewrite the 'else' condition to specifically identify the compatibles
> > > > that utilizing gen2 HW without gals.
> > > > 
> > > > Signed-off-by: Tinghan Shen <tinghan.shen@...iatek.com>
> > > > Reviewed-by: AngeloGioacchino Del Regno
> > > >  <angelogioacchino.delregno@...labora.com>
> > > 
> > > Unfortunately, your patches got corrupted.
> > > 
> > > 
> > > Best regards,
> > > Krzysztof
> > 
> > Do you mean rebase to the latest linux-next?
> > I'll rebase in the next version, thanks!
> 
> Hi TingHan,
> 
> the issue is that some line wrapping happened on your patches, which broke tags
> and also the diffs themselves (it's very obvious on patch 3). So you need to
> sort out your setup so that no longer happens, and resend the patch.
> 
> Thanks,
> Nícolas

I see. I'll send the next version after fix the weired wrapping...
Thank you.


Best regards,
TingHan