linux-kernel - Re: [PATCH 2/2] mfd: lp8788: Fix an error handling path in lp8788_irq_init() and lp8788_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YvOT5wwHtpm3OGP2@google.com>
Date:   Wed, 10 Aug 2022 12:17:59 +0100
From:   Lee Jones <lee@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Samuel Ortiz <sameo@...ux.intel.com>, Milo Kim <Milo.Kim@...com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] mfd: lp8788: Fix an error handling path in
 lp8788_irq_init() and lp8788_irq_init()

On Sun, 31 Jul 2022, Christophe JAILLET wrote:

> In lp8788_irq_init(), if an error occurs after a successful
> irq_domain_add_linear() call, it must be undone by a corresponding
> irq_domain_remove() call.
> 
> irq_domain_remove() should also be called in lp8788_irq_exit() for the same
> reason.
> 
> Fixes: eea6b7cc53aa ("mfd: Add lp8788 mfd driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/mfd/lp8788-irq.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]