linux-kernel - Re: [PATCH v2 1/2] KVM: selftests: Make rseq compatible with glibc-2.35

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <264792101.376.1660134614855.JavaMail.zimbra@efficios.com>
Date:   Wed, 10 Aug 2022 08:30:14 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Gavin Shan <gshan@...hat.com>,
        kvmarm <kvmarm@...ts.cs.columbia.edu>,
        KVM list <kvm@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-kselftest <linux-kselftest@...r.kernel.org>,
        Florian Weimer <fweimer@...hat.com>,
        shan gavin <shan.gavin@...il.com>, maz <maz@...nel.org>,
        andrew jones <andrew.jones@...ux.dev>,
        yihyu <yihyu@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        oliver upton <oliver.upton@...ux.dev>
Subject: Re: [PATCH v2 1/2] KVM: selftests: Make rseq compatible with
 glibc-2.35

----- On Aug 10, 2022, at 8:29 AM, Paolo Bonzini pbonzini@...hat.com wrote:

> On 8/10/22 14:22, Mathieu Desnoyers wrote:
>>>
>>> 	/*
>>> 	 * Create and run a dummy VM that immediately exits to userspace via
>>> @@ -256,7 +244,7 @@ int main(int argc, char *argv[])
>>> 			 */
>>> 			smp_rmb();
>>> 			cpu = sched_getcpu();
>>> -			rseq_cpu = READ_ONCE(__rseq.cpu_id);
>>> +			rseq_cpu = READ_ONCE(__rseq->cpu_id);
>> #include <rseq.h>
>> 
>> and use
>> 
>> rseq_current_cpu_raw().
> 
> Thanks, I squashed it and queued it for -rc1 (tested on both
> glibc 2.34 and 2.35).

Thanks a lot Paolo,

Cheers! :)

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com