linux-kernel - Re: [PATCH v2 1/2] spi: stm32_qspi: Add transfer_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d41e3814-3fab-18a3-7218-d5c28eaecff8@foss.st.com>
Date:   Wed, 10 Aug 2022 15:15:08 +0200
From:   Patrice CHOTARD <patrice.chotard@...s.st.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <linux-spi@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <christophe.kerello@...s.st.com>
Subject: Re: [PATCH v2 1/2] spi: stm32_qspi: Add transfer_one_message() spi
 callback

Hi Mark

On 8/10/22 15:06, Mark Brown wrote:
> On Wed, Aug 10, 2022 at 11:32:14AM +0200, patrice.chotard@...s.st.com wrote:
> 
>> Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>
>>
>> v2: _ use parallel-memories property
>>     _ set auto_runtime_pm to true
>>     _ remove pm_runtime_*() usage in transfer_one_message() callback
>> ---
> 
> The changelog should come after the --- so that it gets automatically
> stripped out by tooling.  No need to resend just for this.
> 
>> +	/*
>> +	 * Dual flash mode is only enable in case "parallel-memories" and
>> +	 * "cs-gpios" properties are found in DT
>> +	 */
>> +	if (of_property_read_bool(dev->of_node, "parallel-memories") &&
>> +	    of_gpio_named_count(dev->of_node, "cs-gpios")) {
>> +		qspi->cr_reg = CR_DFM;
>> +		dev_dbg(dev, "Dual flash mode enable");
>> +	}
> 
> Do we need to add something to the DT bindings to indicate that
> parallel-memories is valid?

You mean in the st,stm32-qspi.yaml DT binding file ? Right i think it could be preferable to add it.


Patrice