linux-kernel - Re: [PATCH 2/3] sched/psi: Remove unused parameter nbytes of psi_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvPK49ywg5wr/bOl@cmpxchg.org>
Date:   Wed, 10 Aug 2022 11:12:35 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Hao Jia <jiahao.os@...edance.com>
Cc:     mingo@...hat.com, peterz@...radead.org, mingo@...nel.org,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] sched/psi: Remove unused parameter nbytes of
 psi_trigger_create()

On Sat, Aug 06, 2022 at 08:05:09PM +0800, Hao Jia wrote:
> psi_trigger_create()'s 'nbytes' parameter is not used, so we can remove it.
> 
> Signed-off-by: Hao Jia <jiahao.os@...edance.com>

Right, it relies on \0-termination which the callers psi_write() and
kernfs_fop_write_iter() guarantee.

Acked-by: Johannes Weiner <hannes@...xchg.org>