linux-kernel - Re: [PATCH 0/3] sched/psi: psi bug fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvPLNNlIyjLXv71v@cmpxchg.org>
Date:   Wed, 10 Aug 2022 11:13:56 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Tejun Heo <tj@...nel.org>
Cc:     Hao Jia <jiahao.os@...edance.com>, mingo@...hat.com,
        peterz@...radead.org, mingo@...nel.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, vschneid@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] sched/psi: psi bug fixes and cleanups

On Tue, Aug 09, 2022 at 07:37:21AM -1000, Tejun Heo wrote:
> (cc'ing Johannes)
> 
> On Sat, Aug 06, 2022 at 08:05:07PM +0800, Hao Jia wrote:
> > These three patches are about PSI.
> > patch 1: Fixed PSI statistics error caused by unzeroed memory
> > in struct psi_group.
> > patch 2 and patch 3 are to clean up some unused functions
> > and parameters.
> > 
> > Hao Jia (3):
> >   sched/psi: Zero the memory of struct psi_group
> >   sched/psi: Remove unused parameter nbytes of psi_trigger_create()
> >   sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS
> > 
> >  include/linux/cgroup.h |  5 -----
> >  include/linux/psi.h    |  2 +-
> >  kernel/cgroup/cgroup.c |  2 +-
> >  kernel/sched/psi.c     | 10 +++-------
> >  4 files changed, 5 insertions(+), 14 deletions(-)
> 
> Johannes, care to review these patches?

They look good to me.

Thanks!