linux-kernel - RE: [EXT] Re: [PATCH v3 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM9PR04MB82740649ABFD62C0821D780589659@AM9PR04MB8274.eurprd04.prod.outlook.com>
Date:   Wed, 10 Aug 2022 15:51:47 +0000
From:   Shenwei Wang <shenwei.wang@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "brgl@...ev.pl" <brgl@...ev.pl>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [EXT] Re: [PATCH v3 1/3] dt-bindings: gpio: Add imx scu gpio
 driver bindings



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, August 10, 2022 10:46 AM
> To: Shenwei Wang <shenwei.wang@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; linus.walleij@...aro.org; brgl@...ev.pl;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; dl-linux-imx <linux-imx@....com>
> Cc: devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> gpio@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; imx@...ts.linux.dev
> Subject: Re: [EXT] Re: [PATCH v3 1/3] dt-bindings: gpio: Add imx scu gpio driver
> bindings
> 
> Caution: EXT Email
> 
> On 10/08/2022 18:23, Shenwei Wang wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Sent: Wednesday, August 10, 2022 9:46 AM
> >> To: Shenwei Wang <shenwei.wang@....com>; robh+dt@...nel.org;
> >> krzysztof.kozlowski+dt@...aro.org; linus.walleij@...aro.org;
> >> brgl@...ev.pl; shawnguo@...nel.org; s.hauer@...gutronix.de;
> >> kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> >> <linux-imx@....com>
> >> Cc: devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> >> gpio@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> >> imx@...ts.linux.dev
> >> Subject: [EXT] Re: [PATCH v3 1/3] dt-bindings: gpio: Add imx scu gpio
> >> driver bindings
> >>
> >> Caution: EXT Email
> >>
> >> On 10/08/2022 16:30, Shenwei Wang wrote:
> >>> Add binding document for the imx scu gpio driver.
> >>>
> >>> Signed-off-by: Shenwei Wang <shenwei.wang@....com>
> >>> ---
> >>>  .../bindings/gpio/fsl,imx-sc-gpio.yaml        | 40 +++++++++++++++++++
> >>> +properties:
> >>> +  compatible:
> >>> +    enum:
> >>> +      - fsl,imx8qxp-sc-gpio
> >>> +      - fsl,imx-scu-gpio
> >>
> >>
> >> This is too generic compatible and it even conflicts with the above...
> >> Your driver binds to both without driver data which is even more confusing.
> >> Make the compatible specific for one, given SoC.
> >>
> >
> > Oh, that's my bad. It is a typo. The generic compatible should be "fsl,imx-sc-
> gpio".
> > So far there is no driver data required for both imx8qxp and imx8dxl,
> > but it might be required sometimes later in case the scu firmware is
> customized for a specified use case.
> > That's why I put the generic one here.
> 
> That's not a proper reason to add generic one. Either all implementations are
> compatible or not. If you are unsure, this should be assumed as not and just use
> specific compatible. If you are 100% sure, then use fallback, not two
> compatibles, and properly justify it.
> 

Okay. I will only keep "fsl,imx8qxp-sc-gpio" for now.

Thanks,
Shenwei

> Best regards,
> Krzysztof