linux-kernel - Re: [PATCH] fs/ntfs3: Remove unused function wnd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a3b479b-dedc-2a73-32fa-5c0440048b7d@paragon-software.com>
Date:   Wed, 10 Aug 2022 19:17:11 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
CC:     <ntfs3@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] fs/ntfs3: Remove unused function wnd_bits



On 7/21/22 06:18, Jiapeng Chong wrote:
> Since the function wnd_bits is defined but not called in any file, it is
> a useless function, and we delete it in view of the brevity of the code.
> 
> Remove some warnings found by running scripts/kernel-doc, which is
> caused by using 'make W=1'.
> 
> fs/ntfs3/bitmap.c:54:19: warning: unused function 'wnd_bits' [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   fs/ntfs3/bitmap.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/fs/ntfs3/bitmap.c b/fs/ntfs3/bitmap.c
> index e3b5680fd516..177c5bc53373 100644
> --- a/fs/ntfs3/bitmap.c
> +++ b/fs/ntfs3/bitmap.c
> @@ -51,11 +51,6 @@ void ntfs3_exit_bitmap(void)
>   	kmem_cache_destroy(ntfs_enode_cachep);
>   }
>   
> -static inline u32 wnd_bits(const struct wnd_bitmap *wnd, size_t i)
> -{
> -	return i + 1 == wnd->nwnd ? wnd->bits_last : wnd->sb->s_blocksize * 8;
> -}
> -
>   /*
>    * wnd_scan
>    *

Applied, thanks!