linux-kernel - Re: [PATCH] irqchip/sifive-plic: Make struct irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-16e473fc-4513-4998-b732-9059d2c0b870@palmer-mbp2014>
Date:   Thu, 11 Aug 2022 09:53:23 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     prabhakar.mahadev-lad.rj@...renesas.com,
        Marc Zyngier <maz@...nel.org>
CC:     tglx@...utronix.de, Paul Walmsley <paul.walmsley@...ive.com>,
        linux-riscv@...ts.infradead.org, geert+renesas@...der.be,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        prabhakar.csengg@...il.com, biju.das.jz@...renesas.com,
        prabhakar.mahadev-lad.rj@...renesas.com
Subject:     Re: [PATCH] irqchip/sifive-plic: Make struct irq_chip const

On Fri, 24 Jun 2022 10:56:39 PDT (-0700), prabhakar.mahadev-lad.rj@...renesas.com wrote:
> These should be const, so make it so.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
>  drivers/irqchip/irq-sifive-plic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index bb87e4c3b88e..173446cc9204 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -176,7 +176,7 @@ static void plic_irq_eoi(struct irq_data *d)
>  	}
>  }
>
> -static struct irq_chip plic_chip = {
> +static const struct irq_chip plic_chip = {
>  	.name		= "SiFive PLIC",
>  	.irq_mask	= plic_irq_mask,
>  	.irq_unmask	= plic_irq_unmask,

Reviewed-by: Palmer Dabbelt <palmer@...osinc.com>
Acked-by: Palmer Dabbelt <palmer@...osinc.com>

Not sure if this got picked up somewhere, but it looks fine to me.