linux-kernel - Re: [PATCH v4] scsi: support packing multi-segment in UNMAP command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a15badd3-b9db-929f-1dc2-863fbff03992@acm.org>
Date:   Thu, 11 Aug 2022 12:34:15 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Chao Yu <chao@...nel.org>
Cc:     jejb@...ux.ibm.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, hch@...radead.org
Subject: Re: [PATCH v4] scsi: support packing multi-segment in UNMAP command

On 6/16/22 19:01, Martin K. Petersen wrote:
>> As SCSI SBC4 specification section 5.30.2 describes that it can
>> support unmapping one or more LBA range in single UNMAP command.
>>
>> However, previously we only pack one LBA range in UNMAP command by
>> default no matter device gives the block limits that says it can
>> support unmapping multiple LBA ranges with a single UNMAP command.
>>
>> This patch sets max_discard_segments config according to block limits
>> of device, and supports unmapping multiple LBA ranges with a single
>> UNMAP command.
> 
> This looks OK to me. Will test with a variety of targets.

Hi Martin,

Have you already had the chance to test this patch? We would like to use 
this functionality in Android.

Thanks,

Bart.