linux-kernel - Re: [PATCH v6] ufs: core: print UFSHCD capabilities in controller's sysfs node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YvVaMJMPVFc4Sa+I@gmail.com>
Date:   Thu, 11 Aug 2022 19:36:16 +0000
From:   Eric Biggers <ebiggers@...nel.org>
To:     Daniil Lunev <dlunev@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Bart Van Assche <bvanassche@....org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Bean Huo <beanhuo@...ron.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Sohaib Mohamed <sohaib.amhmd@...il.com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH v6] ufs: core: print UFSHCD capabilities in controller's
 sysfs node

On Fri, Aug 12, 2022 at 05:32:34AM +1000, Daniil Lunev wrote:
> Hi Eric,
> > This is describing the directory, so please include it in a documentation entry
> > for the directory itself (/sys/bus/platform/drivers/ufshcd/*/capabilities/) just
> > above the documentation entries for the files in the directory.
> 
> Should I keep the comment in this file as well, or remove it here when
> adding to the documentation?
> 
> --Daniil

Avoiding redundancy is nice.  Maybe make the code just refer to the
documentation?

- Eric