linux-kernel - Re: [ldv-project] [PATCH v2] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var()

Open Source and information security mailing list archives

Message-ID: <da72ac1b-57ef-18c5-98c7-f6f1a4c11b8d@ispras.ru>
Date:   Thu, 11 Aug 2022 23:59:00 +0300
From:   Alexey Khoroshilov <khoroshilov@...ras.ru>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Andrey Strachuk <strochuk@...ras.ru>
Cc:     ldv-project@...uxtesting.org,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...ux.ie>, Helge Deller <deller@....de>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Maxime Ripard <mripard@...nel.org>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [ldv-project] [PATCH v2] drm/fb-helper: add virtual screen size
 check to drm_fb_helper_check_var()

For v2 I would suggest to update description to something like this:

Make sure that virtual screen size is not less than physical screen one.

and comment to:
    /* make sure that virtual resolution >= physical resolution */

--
Alexey

On 11.08.2022 17:54, Geert Uytterhoeven wrote:
> Hi Andrey,
> 
> On Thu, Aug 11, 2022 at 4:49 PM Andrey Strachuk <strochuk@...ras.ru> wrote:
>> Add virtual screen size check to drm_fb_helper_check_var() in
>> order to validate userspace input.
>>
>> Found by Linux Verification Center (linuxtesting.org) with syzkaller.
>>
>> Signed-off-by: Andrey Strachuk <strochuk@...ras.ru>
> 
> Thanks for the update!
> 
>> Fixes: 785b93ef8c30 ("drm/kms: move driver specific fb common code to helper functions (v2)")
> 
> I'd drop the Fixes tag completely, as the bug was present in the
> intel and radeon drivers before. But probably it doesn't matter, as no one
> is gonna backport this to v2.6.31 and earlier ;-)
> 
> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
> _______________________________________________
> ldv-project mailing list
> ldv-project@...uxtesting.org
> http://linuxtesting.org/cgi-bin/mailman/listinfo/ldv-project
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives