linux-kernel - Re: [PATCH] mm/uffd: Reset write protection when unregister with wp-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220811150105.ce8636e7f101545d12d6cfac@linux-foundation.org>
Date:   Thu, 11 Aug 2022 15:01:05 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Peter Xu <peterx@...hat.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        David Hildenbrand <david@...hat.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Nadav Amit <nadav.amit@...il.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>
Subject: Re: [PATCH] mm/uffd: Reset write protection when unregister with
 wp-mode

On Thu, 11 Aug 2022 17:23:14 -0400 Peter Xu <peterx@...hat.com> wrote:

> On Thu, Aug 11, 2022 at 02:11:44PM -0700, Andrew Morton wrote:
> > On Thu, 11 Aug 2022 16:13:40 -0400 Peter Xu <peterx@...hat.com> wrote:
> > 
> > > I added a Fixes upon introducing of uffd-wp shmem+hugetlbfs because that's
> > > the only issue reported so far and that's the commit David's reproducer
> > > will start working (v5.19+).  But the whole idea actually applies to not
> > > only file memories but also anonymous.  It's just that we don't need to fix
> > > anonymous prior to v5.19- because there's no known way to exploit.
> > 
> > I added a cc:stable to this.
> 
> Thanks, Andrew.  I'll remember to do so in future patches when Fixes apply.
> 

Only if we want the fix to be backported!

I mean, it's legitimate and sensible to add a Fixes: to a patch which
fixes a comment typo, but we don't want that backported.

And sometimes a fix is too complex and the problem too small to warrant
a backport, but we still want that Fixes: tag.