linux-kernel - Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef32187cf1090de6e8cda2bf0218985cd3f4c21e.camel@ljones.dev>
Date:   Fri, 12 Aug 2022 10:08:25 +1200
From:   Luke Jones <luke@...nes.dev>
To:     Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Barnabás Pőcze <pobrn@...tonmail.com>,
        Pavel Machek <pavel@....cz>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes

Hi,

On Thu, 2022-08-11 at 17:08 +0200, Hans de Goede wrote:
> Hi,
> 
> On 8/9/22 11:25, Andy Shevchenko wrote:
> > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@...nes.dev>
> > wrote:
> > > 
> > > Documents some previously added attributes:
> > > - dgpu_disable
> > > - egpu_enable
> > > - panel_od
> > 
> > Try to find a commit that introduced thouse and add the respective
> > Fixes tag.
> > 
> > ...
> > 
> > > -                       * keyboard - 0 or 1, unknown what effect
> > > this really has
> > > \ No newline at end of file
> > > +                       * keyboard - 0 or 1, unknown what effect
> > > this really has
> > 
> > Should be part of another patch.
> 
> Ack to both remarks.
> 
> Luke please make this patch one of the first patches in your next
> version / patch-series and then add the doucmentation of the new
> kbd RGB backlight attributes in the patches where you are also
> adding those actual attributes.

Yep, done. Everything is looking much cleaner too.