linux-kernel - Re: [PATCH] ALSA: hda: Fix crash due to jack poll in suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878rnvuybo.wl-tiwai@suse.de>
Date:   Thu, 11 Aug 2022 07:46:35 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Mohan Kumar <mkumard@...dia.com>
Cc:     <tiwai@...e.com>, <perex@...ex.cz>, <cezary.rojewski@...el.com>,
        <treding@...dia.com>, <jonathanh@...dia.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda: Fix crash due to jack poll in suspend

On Thu, 11 Aug 2022 07:27:04 +0200,
Mohan Kumar wrote:
> 
> With jackpoll_in_suspend flag set, there is a possibility that
> jack poll worker thread will run even after system suspend was
> completed. Any register access after system pm callback flow
> will result in kernel crash as still jack poll worker thread
> tries to access registers.
> 
> To fix the crash issue during system flow, cancel the jack poll
> worker thread during system pm prepare callback and cancel the
> worker thread at start of runtime suspend callback and re-schedule
> at last to avoid any unwarranted access of register by worker thread
> during suspend flow.
> 
> Signed-off-by: Mohan Kumar <mkumard@...dia.com>

Thanks, applied now with Fixes tag.


Takashi