linux-kernel - Re: [PATCH v5 00/17] perf c2c: Support data source and display for Arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220811064122.GA860078@leoy-huanghe.lan>
Date:   Thu, 11 Aug 2022 14:41:22 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        John Garry <john.garry@...wei.com>,
        Will Deacon <will@...nel.org>,
        James Clark <james.clark@....com>,
        German Gomez <german.gomez@....com>,
        Ali Saidi <alisaidi@...zon.com>, Joe Mario <jmario@...hat.com>,
        Adam Li <adam.li@...erecomputing.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 00/17] perf c2c: Support data source and display for
 Arm64

Hi Arnaldo,

On Wed, Aug 10, 2022 at 10:37:32AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Jun 04, 2022 at 12:28:03PM +0800, Leo Yan escreveu:
> > Arm64 Neoverse CPUs supports data source in Arm SPE trace, this allows
> > us to detect cache line contention and transfers.
> > 
> > This patch set includes Ali's patch set v9 "perf: arm-spe: Decode SPE
> > source and use for perf c2c" [1] and rebased on the latest perf core
> > banch with latest commit 1bcca2b1bd67 ("perf vendor events intel:
> > Update metrics for Alderlake").
> > 
> > Patches 01-05 comes from Ali's patch set to support data source for Arm
> > SPE for neoverse cores.
> 
> Leo, please remove touching the kernel perf_event.h on the first patch,
> I see it doesn't affect the kernel right now as it is done just from
> synthesizing perf records from hw trace data, and we haven't received
> any review comment from Peter Zijlstra (I think he is in vacations).

Done!  The new patch set іs in below link, which dropped the patch for
kernel perf_event.h:
https://lore.kernel.org/lkml/20220811062451.435810-1-leo.yan@linaro.org/

One question: should I later continue to upstream the first patch for
syncing the kernel header perf_event.h after Peter.Z comes back?


> Also please refresh it:
> 
> ⬢[acme@...lbox perf]$        git am ./v5_20220604_leo_yan_perf_c2c_support_data_source_and_display_for_arm64.mbx
> Applying: perf: Add SNOOP_PEER flag to perf mem data struct
> Applying: perf tools: sync addition of PERF_MEM_SNOOPX_PEER
> Applying: perf mem: Print snoop peer flag
> Applying: perf arm-spe: Don't set data source if it's not a memory operation
> error: patch failed: tools/perf/util/arm-spe.c:387
> error: tools/perf/util/arm-spe.c: patch does not apply
> Patch failed at 0004 perf arm-spe: Don't set data source if it's not a memory operation
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> ⬢[acme@...lbox perf]$

To fix the merging conflict in the new patch set, I also dropped the
patch "perf arm-spe: Don't set data source if it's not a memory
operation", since this patch has been merged into the mainline kernel.

Note, when verified the patch set, I found a compilation error, so I
sent a separate patch to fix it:
https://lore.kernel.org/lkml/20220811044341.426796-1-leo.yan@linaro.org/

Thanks a lot for continuous tracking this series.

Leo