linux-kernel - Re: [PATCH] dma/pool: do not complain if DMA pool is not allocated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220811072726.GA13886@lst.de>
Date:   Thu, 11 Aug 2022 09:27:26 +0200
From:   Christoph Hellwig <hch@....de>
To:     Michal Hocko <mhocko@...e.com>
Cc:     Christoph Hellwig <hch@....de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Baoquan He <bhe@...hat.com>,
        John Donnelly <john.p.donnelly@...cle.com>,
        David Hildenbrand <david@...hat.com>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dma/pool: do not complain if DMA pool is not allocated

On Fri, Mar 25, 2022 at 05:54:32PM +0100, Michal Hocko wrote:
> > > I thought there are only few pages in the managed by the DMA zone. This
> > > is still theoretically possible so I think __GFP_NOWARN makes sense here
> > > but it would require to change the patch description.
> > > 
> > > Is this really worth it?
> > 
> > In general I think for kernels where we need the pool and can't allocate
> > it, a warning is very useful.  We just shouldn't spew it when there is
> > no need for the pool to start with.
> 
> Well, do we have any way to find that out during early boot?

In general an architecture / configuration that selects
CONFIG_ZONE_DMA needs it.  We could try to reduce that dependency and/or
make it boot time configurable, but there's still plenty of device with
sub-32bit addessing limits around, so I'm not sure it would help much.