linux-kernel - Re: 回复: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YvSycPr+co+G5j+K@zn.tnic>
Date:   Thu, 11 Aug 2022 09:40:32 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Justin He <Justin.He@....com>
Cc:     "Kani, Toshi" <toshi.kani@....com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, James Morse <James.Morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>, nd <nd@....com>
Subject: Re: 回复: [PATCH] ACPI: APEI:
 move edac_init ahead of ghes platform drv register

On Thu, Aug 11, 2022 at 12:39:10AM +0000, Justin He wrote:
> > +static int __init ghes_edac_init(void)
> > +{
> > +	struct ghes *g, *g_tmp;
> > +
> > +	ghes_devs = ghes_get_devices(force_load);
> > +	if (ghes_devs)
> Should it be changed to if(!ghes_devs) ?
> Otherwise, this ghes_edac_init() on Arm will always return with ENODEV
> because ! ghes_get_devices().

Yes, of course, sorry about that.

I mean, for a lack of a better idea, it returns a list of devices... ;-\

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette