linux-kernel - Re: [PATCH] usb/serial:Modify the return value to void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvS8AK9apa7tnYOz@kroah.com>
Date:   Thu, 11 Aug 2022 10:21:20 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Zhou jie <zhoujie@...china.com>
Cc:     johan@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...china.com
Subject: Re: [PATCH] usb/serial:Modify the return value to void

On Thu, Aug 11, 2022 at 03:03:58PM +0800, Zhou jie wrote:
> Modify the return value to void,The return value is not used elsewhere.
> 
> Signed-off-by: Zhou jie <zhoujie@...china.com>
> ---
>  drivers/usb/serial/mos7720.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 1e12b5f30dcc..ddb3a2d0f819 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -239,13 +239,12 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum,
>  
>  #ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT
>  
> -static inline int mos7715_change_mode(struct mos7715_parport *mos_parport,
> +static inline void mos7715_change_mode(struct mos7715_parport *mos_parport,
>  				      enum mos7715_pp_modes mode)
>  {
>  	mos_parport->shadowECR = mode;
>  	write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
>  		      mos_parport->shadowECR);
> -	return 0;

Why not check the return value of write_mos_reg() and properly handle
the error that can give you instead of ignoring it?

thanks,

greg k-h