linux-kernel - Re: [PATCH] dma/pool: do not complain if DMA pool is not allocated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvS87E6Vx/3PvMPr@dhcp22.suse.cz>
Date:   Thu, 11 Aug 2022 10:25:16 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Baoquan He <bhe@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        John Donnelly <john.p.donnelly@...cle.com>,
        David Hildenbrand <david@...hat.com>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dma/pool: do not complain if DMA pool is not allocated

On Thu 11-08-22 09:38:40, Christoph Hellwig wrote:
> On Tue, Aug 09, 2022 at 05:37:59PM +0200, Michal Hocko wrote:
> > Here we go again.
> 
> And just as last time I think this is the wrong thing to do.
> IFF we actually need the pool and we can't allocate it we want this
> warning.
> 
> But order-10 seems very larger for the 31-bit ISA DMA zone, so we might
> want to look into calculating the pool size based on the zone size
> instead.

No objection for a better size tuning from my side. I find it 
I suspect you will need __GFP_NOWARN to be used for downsizing the
request size for all attempts anyway.

-- 
Michal Hocko
SUSE Labs