linux-kernel - Re: [PATCH] x86/apic: Don't disable x2APIC if locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76b3c2703d13252d1dba1b7f32675951d6b27e28.camel@intel.com>
Date:   Thu, 11 Aug 2022 08:29:37 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "Hansen, Dave" <dave.hansen@...el.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Shutemov, Kirill" <kirill.shutemov@...el.com>,
        "daniel.sneddon@...ux.intel.com" <daniel.sneddon@...ux.intel.com>
CC:     "hpa@...or.com" <hpa@...or.com>,
        "pawan.kumar.gupta@...ux.intel.com" 
        <pawan.kumar.gupta@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Gomez Iglesias, Antonio" <antonio.gomez.iglesias@...el.com>
Subject: Re: [PATCH] x86/apic: Don't disable x2APIC if locked

On Wed, 2022-08-10 at 16:09 -0700, Dave Hansen wrote:
> On 8/10/22 16:03, Daniel Sneddon wrote:
> > On 8/10/22 15:06, Thomas Gleixner wrote:
> > > So this affects already deployed systems and we have to
> > > 
> > >   - backport the x2apic lock changes
> > > 
> > >   - provide proper diagnostics
> > > 
> > >   - make SGX and TDX depend on X2APIC support
> > I'll add the comments Dave mentioned earlier, and will make SGX and TDX depend
> > on X2APIC since that makes sense regardless of what hw ends up with this change.
> >  Unless we want to get rid of CONFIG_X86_X2APIC like Dave mentioned?
> 
> The TDX guest support in the kernel isn't _actually_ related to this*.
> It's the host-side support that matters and that isn't merged yet.  I've
> cc'd Kai so he doesn't forget to do this.
> 
> 

Hi Dave,

Thanks for the info.  I'll address this before sending out next version.

-- 
Thanks,
-Kai